loop: don't require ->write_iter for writable files in loop_configure

[ Upstream commit 355341e4359b2d5edf0ed5e117f7e9e7a0a5dac0 ]

Block devices can be opened read-write even if they can't be written to
for historic reasons.  Remove the check requiring file->f_op->write_iter
when the block devices was opened in loop_configure. The call to
loop_check_backing_file just below ensures the ->write_iter is present
for backing files opened for writing, which is the only check that is
actually needed.

Fixes: f5c84eff634b ("loop: Add sanity check for read/write_iter")
Reported-by: Christian Hesse <mail@eworm.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20250520135420.1177312-1-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index f68f86e9cb716be3e0382505fbd6e49b4bd251b6..0b135d1ca25ea0b7400e833aee1471d8f6b9ce6a 100644 (file)
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -973,9 +973,6 @@ static int loop_configure(struct loop_device *lo, blk_mode_t mode,
        if (!file)
                return -EBADF;
 
-       if ((mode & BLK_OPEN_WRITE) && !file->f_op->write_iter)
-               return -EINVAL;
-
        error = loop_check_backing_file(file);
        if (error)
                return error;