CID 1341682: Nit in libntp/authreadkeys.c. HStenn.

bk: 5662b60bRrhmXVYfYG8w9OhEYo50-g

diff --git a/ChangeLog b/ChangeLog
index 21c8cf7ac5622f3a5f9ea00d7cbeb444489d83f5..592e0c039d7063bcfca489ab908aaaed9a6c89d3 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -10,6 +10,7 @@
 * CID 1341536: Resource leak in tests/ntpd/t-ntp_signd.c.  HStenn.
 * CID 1341537: Resource leak in tests/ntpd/t-ntp_signd.c.  HStenn.
 * CID 1341538: Memory leak in tests/ntpd/ntp_prio_q.c:262.  HStenn.
+* CID 1341682: Nit in libntp/authreadkeys.c.  HStenn.
 * CID 1341684: Nit in tests/ntpd/t-ntp_signd.c.  HStenn.
 * [Bug 2829] Look at pipe_fds in ntpd.c  (did so. perlinger@ntp.org)
 * [Bug 2887] stratum -1 config results as showing value 99

diff --git a/libntp/authreadkeys.c b/libntp/authreadkeys.c
index 5107dd0962f2a82a43c399ff3bf71e585b8cb76b..95a357a8c6651adcfa4b1f75e398f4a3d5a6cd17 100644 (file)
--- a/libntp/authreadkeys.c
+++ b/libntp/authreadkeys.c
@@ -262,10 +262,9 @@ authreadkeys(
                        next->seclen  = len;
                        memcpy(next->secbuf, keystr, len);
                }
-               if (next) {
-                       next->next = list;
-                       list = next;
-               }
+               INSIST(NULL != next);
+               next->next = list;
+               list = next;
        }
        fclose(fp);
        if (nerr > nerr_maxlimit) {