]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
winbindd: idmap_rid: error code for failing id-to-sid mapping request
authorRalph Boehme <slow@samba.org>
Mon, 9 Oct 2017 11:29:05 +0000 (13:29 +0200)
committerKarolin Seeger <kseeger@samba.org>
Thu, 14 Dec 2017 15:20:49 +0000 (16:20 +0100)
NT_STATUS_NO_SUCH_DOMAIN triggers complete request failure in the parent
winbindd. By returning NT_STATUS_NONE_MAPPED winbindd lets the individual
mapping fail but keeps processing any remaining mapping requests.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13052

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Oct 10 19:57:37 CEST 2017 on sn-devel-144

(cherry picked from commit 490c35df35bad6c2f1c4acd2f056d6fdc480ec1f)

Autobuild-User(v4-6-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-6-test): Thu Dec 14 16:20:49 CET 2017 on sn-devel-144

source3/winbindd/idmap_rid.c

index 95e24db5290f1acc8bdb02ef9b59b0383358d3f3..074eaa1149bec8ba8fe7b4c2516deb81b6a73166 100644 (file)
@@ -81,7 +81,7 @@ static NTSTATUS idmap_rid_id_to_sid(struct idmap_domain *dom, struct id_map *map
 
        if (is_null_sid(&dom->dom_sid)) {
                DBG_INFO("idmap domain '%s' without SID\n", dom->name);
-               return NT_STATUS_NO_SUCH_DOMAIN;
+               return NT_STATUS_NONE_MAPPED;
        }
 
        sid_compose(map->sid, &dom->dom_sid,