autobuild.sh: Fix minor shell-quoting bugs.

* autobuild.sh: Remove unnecessary quotes.
Don't choke on a file name argument containing a space.
Don't misbehave for $AUTOBUILD_INSTALL_ROOT containing
a shell meta-character.

diff --git a/ChangeLog b/ChangeLog
index 7a2e1e70347f2892554fa517d932e052c1b9ed7c..765c6d2bfe2b11e138fb6dc85eef301a4efa8d9c 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+Thu Aug 21 21:29:28 CEST 2008 Jim Meyering <meyering@redhat.com>
+
+       autobuild.sh: Fix minor shell-quoting bugs.
+       * autobuild.sh: Remove unnecessary quotes.
+       Don't choke on a file name argument containing a space.
+       Don't misbehave for $AUTOBUILD_INSTALL_ROOT containing
+       a shell meta-character.
+
 Wed Aug 21 11:14:09 BST 2008 Daniel P. Berrange <berrange@redhat.com>
 
        * src/remote_internal.c: Clarify error messages from various

diff --git a/autobuild.sh b/autobuild.sh
index ce1269258fe602fef0169c6c5074666ca69ac385..7ae5d1e76a03a5f7370e2d3c9bf29eaf1a57d7ae 100755 (executable)
--- a/autobuild.sh
+++ b/autobuild.sh
@@ -5,7 +5,7 @@ set -v
 
 # Make things clean.
 
-test -n "$1" && RESULTS="$1" || RESULTS="results.log"
+test -n "$1" && RESULTS=$1 || RESULTS=results.log
 
 test -f Makefile && make -k distclean || :
 rm -rf coverage
@@ -14,7 +14,7 @@ rm -rf coverage
 #mkdir build
 #cd build
 
-./autogen.sh --prefix=$AUTOBUILD_INSTALL_ROOT \
+./autogen.sh --prefix="$AUTOBUILD_INSTALL_ROOT" \
   --enable-test-coverage \
   --enable-compile-warnings=error \
   --with-openvz \
@@ -25,8 +25,8 @@ make
 make install
 
 set -o pipefail
-make check 2>&1 | tee $RESULTS
-make syntax-check 2>&1 | tee -a $RESULTS
+make check 2>&1 | tee "$RESULTS"
+make syntax-check 2>&1 | tee -a "$RESULTS"
 test -x /usr/bin/lcov && make cov
 
 rm -f *.tar.gz