]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
vircgroupv2devices: fix counting entries in BPF map
authorPavel Hrdina <phrdina@redhat.com>
Tue, 11 Aug 2020 09:07:06 +0000 (11:07 +0200)
committerPavel Hrdina <phrdina@redhat.com>
Tue, 11 Aug 2020 13:11:15 +0000 (15:11 +0200)
BPF syscall BPF_MAP_GET_NEXT_KEY returns -1 if something fails but it
will also return -1 if trying to get next key using the last key in the
map with errno set to ENOENT.

If there are VMs running and libvirtd is restarted and user tries to
call some cgroup devices operation on a VM we need to get the count of
entries in BPF map and it fails which will result in error when trying
to attach/detech devices.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1833321

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/util/vircgroupv2devices.c

index d62ee12a05ee7d6e096f35c2619acd9582f3ba39..234e0f227893c2f5ba1ef659f192c5eee2e00340 100644 (file)
@@ -342,7 +342,7 @@ virCgroupV2DevicesCountMapEntries(int mapfd)
         prevKey = key;
     }
 
-    if (rc < 0)
+    if (rc < 0 && errno != ENOENT)
         return -1;
 
     return ret;