gccrs: Fix missing dead code analysis ICE on local enum definition

When resolving local enum's within a Block the name resolution info is
not at the top of the stack so this patch introduces a new mappings class
for miscellaneous name resolutions which can be used during path analaysis.

Fixes #1272

gcc/rust/ChangeLog:

	* resolve/rust-name-resolver.h: Add miscellenaous item mappings.
	* resolve/rust-name-resolver.cc (Resolver::insert_resolved_misc): Use
	new mappings.
	(Resolver::lookup_resolved_misc): Likewise.
	* typecheck/rust-hir-type-check-path.cc (TypeCheckExpr::resolve_segments):
	Adapt function to insert into miscelleanous mappings.
	* checks/lints/rust-lint-marklive.cc (MarkLive::find_ref_node_id):
	Allow lookup in miscelleanous mappings in mark-live phase.

gcc/testsuite/ChangeLog:

	* rust/compile/issue-1272.rs: New test.

diff --git a/gcc/rust/checks/lints/rust-lint-marklive.cc b/gcc/rust/checks/lints/rust-lint-marklive.cc
index 14115c86f26c698fcaa1331f209536334df98539..c914b549257008ff5997f3c39133d4113a718681 100644 (file)
--- a/gcc/rust/checks/lints/rust-lint-marklive.cc
+++ b/gcc/rust/checks/lints/rust-lint-marklive.cc
@@ -273,8 +273,11 @@ MarkLive::find_ref_node_id (NodeId ast_node_id, NodeId &ref_node_id)
 {
   if (!resolver->lookup_resolved_name (ast_node_id, &ref_node_id))
     {
-      bool ok = resolver->lookup_resolved_type (ast_node_id, &ref_node_id);
-      rust_assert (ok);
+      if (!resolver->lookup_resolved_type (ast_node_id, &ref_node_id))
+       {
+         bool ok = resolver->lookup_resolved_misc (ast_node_id, &ref_node_id);
+         rust_assert (ok);
+       }
     }
 }
 

diff --git a/gcc/rust/resolve/rust-name-resolver.cc b/gcc/rust/resolve/rust-name-resolver.cc
index 77d98d5f3644e8aef2e3f4ab991396c7ebced071..b94713d3c30f7a10f886efe89ace62a1fb921d8c 100644 (file)
--- a/gcc/rust/resolve/rust-name-resolver.cc
+++ b/gcc/rust/resolve/rust-name-resolver.cc
@@ -499,5 +499,25 @@ Resolver::lookup_resolved_macro (NodeId refId, NodeId *defId)
   return true;
 }
 
+void
+Resolver::insert_resolved_misc (NodeId refId, NodeId defId)
+{
+  auto it = misc_resolved_items.find (refId);
+  rust_assert (it == misc_resolved_items.end ());
+
+  misc_resolved_items[refId] = defId;
+}
+
+bool
+Resolver::lookup_resolved_misc (NodeId refId, NodeId *defId)
+{
+  auto it = misc_resolved_items.find (refId);
+  if (it == misc_resolved_items.end ())
+    return false;
+
+  *defId = it->second;
+  return true;
+}
+
 } // namespace Resolver
 } // namespace Rust

diff --git a/gcc/rust/resolve/rust-name-resolver.h b/gcc/rust/resolve/rust-name-resolver.h
index 6f4dda06a5c1e4c4d9ac30dcbde84c720e3944d5..302b0de15ccec1e8d58bd276d3bd5f203241929f 100644 (file)
--- a/gcc/rust/resolve/rust-name-resolver.h
+++ b/gcc/rust/resolve/rust-name-resolver.h
@@ -126,6 +126,9 @@ public:
   void insert_resolved_macro (NodeId refId, NodeId defId);
   bool lookup_resolved_macro (NodeId refId, NodeId *defId);
 
+  void insert_resolved_misc (NodeId refId, NodeId defId);
+  bool lookup_resolved_misc (NodeId refId, NodeId *defId);
+
   // proxy for scoping
   Scope &get_name_scope () { return name_scope; }
   Scope &get_type_scope () { return type_scope; }
@@ -202,6 +205,9 @@ private:
   std::map<NodeId, NodeId> resolved_labels;
   std::map<NodeId, NodeId> resolved_macros;
 
+  // misc
+  std::map<NodeId, NodeId> misc_resolved_items;
+
   // keep track of the current module scope ids
   std::vector<NodeId> current_module_stack;
 };

diff --git a/gcc/rust/typecheck/rust-hir-type-check-path.cc b/gcc/rust/typecheck/rust-hir-type-check-path.cc
index f404ea64bcc295a735690fc6dbe74dec84e1811f..305d73f76f97e188a2a79d2050fc5cb1179a85ad 100644 (file)
--- a/gcc/rust/typecheck/rust-hir-type-check-path.cc
+++ b/gcc/rust/typecheck/rust-hir-type-check-path.cc
@@ -462,6 +462,11 @@ TypeCheckExpr::resolve_segments (NodeId root_resolved_node_id,
       resolver->insert_resolved_type (expr_mappings.get_nodeid (),
                                      resolved_node_id);
     }
+  else
+    {
+      resolver->insert_resolved_misc (expr_mappings.get_nodeid (),
+                                     resolved_node_id);
+    }
 
   infered = tyseg;
 }

diff --git a/gcc/testsuite/rust/compile/issue-1272.rs b/gcc/testsuite/rust/compile/issue-1272.rs
new file mode 100644 (file)
index 0000000..08adaaf
--- /dev/null
+++ b/gcc/testsuite/rust/compile/issue-1272.rs
@@ -0,0 +1,8 @@
+fn main() -> i32 {
+    enum E {
+        X(u8),
+    }
+    let _v = E::X(4);
+
+    0
+}