]> git.ipfire.org Git - thirdparty/apache/httpd.git/commitdiff
mod_ssl: revert r1781299 r1781188.
authorYann Ylavic <ylavic@apache.org>
Wed, 1 Feb 2017 21:17:20 +0000 (21:17 +0000)
committerYann Ylavic <ylavic@apache.org>
Wed, 1 Feb 2017 21:17:20 +0000 (21:17 +0000)
Need to separate follow up related to r1740928 and co from the one related to
r1781187.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1781311 13f79535-47bb-0310-9956-ffa450edef68

modules/ssl/ssl_engine_config.c
modules/ssl/ssl_engine_init.c

index f1be77aefeb2b7d68b13dc6b264b34ff902c3fbf..7cc21138bd2870b9bf8eca5903c589ba7b5228cc 100644 (file)
@@ -98,14 +98,6 @@ BOOL ssl_config_global_isfixed(SSLModConfigRec *mc)
 **  _________________________________________________________________
 */
 
-#ifdef HAVE_SSL_CONF_CMD
-static apr_status_t modssl_ctx_config_cleanup(void *ctx)
-{
-    SSL_CONF_CTX_free(ctx);
-    return APR_SUCCESS;
-}
-#endif
-
 static void modssl_ctx_init(modssl_ctx_t *mctx, apr_pool_t *p)
 {
     mctx->sc                  = NULL; /* set during module init */
@@ -165,9 +157,6 @@ static void modssl_ctx_init(modssl_ctx_t *mctx, apr_pool_t *p)
 #endif
 #ifdef HAVE_SSL_CONF_CMD
     mctx->ssl_ctx_config = SSL_CONF_CTX_new();
-    apr_pool_cleanup_register(p, mctx->ssl_ctx_config,
-                              modssl_ctx_config_cleanup,
-                              apr_pool_cleanup_null);
     SSL_CONF_CTX_set_flags(mctx->ssl_ctx_config, SSL_CONF_FLAG_FILE);
     SSL_CONF_CTX_set_flags(mctx->ssl_ctx_config, SSL_CONF_FLAG_SERVER);
     SSL_CONF_CTX_set_flags(mctx->ssl_ctx_config, SSL_CONF_FLAG_CERTIFICATE);
index fe37d84bc5a5ba25e33e2f1124c15faa1f0822e2..ea1dede138066afcef1c9a0b4c2854ac3ce87b47 100644 (file)
@@ -1615,11 +1615,6 @@ static apr_status_t ssl_init_proxy_ctx(server_rec *s,
 {
     apr_status_t rv;
 
-    if (proxy->ssl_ctx) {
-        /* Merged/initialized already */
-        return APR_SUCCESS;
-    }
-
     apr_pool_cleanup_register(p, proxy,
                               ssl_cleanup_proxy_ctx,
                               apr_pool_cleanup_null);
@@ -1690,6 +1685,7 @@ static apr_status_t ssl_init_server_ctx(server_rec *s,
             ssl_log_ssl_error(SSLLOG_MARK, APLOG_EMERG, s);
             return ssl_die(s);
     }
+    SSL_CONF_CTX_free(cctx);
 #endif
 
     if (SSL_CTX_check_private_key(sc->server->ssl_ctx) != 1) {