]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
Specify view columns in HasTableTest
authorGord Thompson <gord@gordthompson.com>
Fri, 9 Dec 2022 16:55:34 +0000 (09:55 -0700)
committerGord Thompson <gord@gordthompson.com>
Fri, 9 Dec 2022 16:55:34 +0000 (09:55 -0700)
Fixes: #8960
Avoid test errors on databases that do not
support CREATE VIEW vv AS SELECT * FROM

Change-Id: Ic9e892aa4466030b9b325c11228dad15cf59a258

lib/sqlalchemy/testing/suite/test_reflection.py

index 60f8fabf17b051faff42cabce84b06d3d6d4fbc0..2550eff4e81496610bf49ed76bf6ba0b41fb46c1 100644 (file)
@@ -88,15 +88,18 @@ class HasTableTest(OneConnectionTablesTest):
 
     @classmethod
     def define_views(cls, metadata):
-        query = "CREATE VIEW vv AS SELECT * FROM test_table"
+        query = "CREATE VIEW vv AS SELECT id, data FROM test_table"
 
         event.listen(metadata, "after_create", DDL(query))
         event.listen(metadata, "before_drop", DDL("DROP VIEW vv"))
 
         if testing.requires.schemas.enabled:
-            query = "CREATE VIEW %s.vv AS SELECT * FROM %s.test_table_s" % (
-                config.test_schema,
-                config.test_schema,
+            query = (
+                "CREATE VIEW %s.vv AS SELECT id, data FROM %s.test_table_s"
+                % (
+                    config.test_schema,
+                    config.test_schema,
+                )
             )
             event.listen(metadata, "after_create", DDL(query))
             event.listen(