]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
smp: Use system_percpu_wq instead of system_wq
authorMarco Crivellari <marco.crivellari@suse.com>
Mon, 10 Nov 2025 17:03:32 +0000 (18:03 +0100)
committerThomas Gleixner <tglx@kernel.org>
Thu, 26 Mar 2026 16:31:35 +0000 (17:31 +0100)
When a caller enqueues a work item using schedule_delayed_work() the used
wq is "system_wq" (per-cpu wq) while queue_delayed_work() uses
WORK_CPU_UNBOUND (used when no target CPU is specified). The same applies
to schedule_work() that is using system_wq and queue_work(), which again
makes use of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.

Continue the effort to refactor workqueue APIs, which began with the
introduction of new workqueues and a new alloc_workqueue() flag in:

  commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
  commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

and switch smp_call_on_cpu() to use system_percpu_wq because system_wq is
going away once the ongoing workqueue restructuring is done.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://patch.msgid.link/20251110170332.319314-1-marco.crivellari@suse.com
kernel/smp.c

index 0fc4ff28ba79eb1109236e2e4b29e0a8a651a5fc..6c77848d91f30e27f28ac13c3091e67a249ca3c8 100644 (file)
@@ -1185,7 +1185,7 @@ int smp_call_on_cpu(unsigned int cpu, int (*func)(void *), void *par, bool phys)
        if (cpu >= nr_cpu_ids || !cpu_online(cpu))
                return -ENXIO;
 
-       queue_work_on(cpu, system_wq, &sscs.work);
+       queue_work_on(cpu, system_percpu_wq, &sscs.work);
        wait_for_completion(&sscs.done);
        destroy_work_on_stack(&sscs.work);