]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
http_server.c: fix checks of error return code in http_server_init()
authorDavid von Oheimb <dev@ddvo.net>
Wed, 31 Jul 2024 17:32:44 +0000 (19:32 +0200)
committerTomas Mraz <tomas@openssl.org>
Mon, 23 Sep 2024 20:15:39 +0000 (22:15 +0200)
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25010)

apps/lib/http_server.c

index e80ad14eb66c0958fb2ac5cc61883d5862437577..a5a86ecbc54c63d99ec54b3e46de4d8b7c860c9a 100644 (file)
@@ -204,8 +204,8 @@ BIO *http_server_init(const char *prog, const char *port, int verb)
         goto err;
     acbio = BIO_new(BIO_s_accept());
     if (acbio == NULL
-        || BIO_set_bind_mode(acbio, BIO_BIND_REUSEADDR) < 0
-        || BIO_set_accept_name(acbio, name) < 0) {
+        || BIO_set_bind_mode(acbio, BIO_BIND_REUSEADDR) <= 0
+        || BIO_set_accept_name(acbio, name) <= 0) {
         log_HTTP(prog, LOG_ERR, "error setting up accept BIO");
         goto err;
     }