mptcp: make sure flag signal is set when add addr with port

When add address with port, it is mean to send an ADD_ADDR to remote,
so it must have flag signal set.

Fixes: 42fbca91cd61 ("mptcp: add support for port based endpoint")
Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
Acked-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: David Ahern <dsahern@kernel.org>

diff --git a/ip/ipmptcp.c b/ip/ipmptcp.c
index 5f490f0026d9664ada7e376a59a3b0f70891b7b9..44af7234267b8eff41754675952e9b90215f52e0 100644 (file)
--- a/ip/ipmptcp.c
+++ b/ip/ipmptcp.c
@@ -143,6 +143,9 @@ static int mptcp_parse_opt(int argc, char **argv, struct nlmsghdr *n,
        if (!id_set && !adding)
                missarg("ID");
 
+       if (port && !(flags & MPTCP_PM_ADDR_FLAG_SIGNAL))
+               invarg("flags must have signal when using port", "port");
+
        attr_addr = addattr_nest(n, MPTCP_BUFLEN,
                                 MPTCP_PM_ATTR_ADDR | NLA_F_NESTED);
        if (id_set)