request->packet cannot be NULL. Helps with #1935

diff --git a/src/modules/rlm_cache/rlm_cache.c b/src/modules/rlm_cache/rlm_cache.c
index 248de8bf9b7de8faa736192a20839120533697bb..54449747f48b504f0ffba038ccd8756965eda039 100644 (file)
--- a/src/modules/rlm_cache/rlm_cache.c
+++ b/src/modules/rlm_cache/rlm_cache.c
@@ -126,7 +126,8 @@ static void CC_HINT(nonnull) cache_merge(rlm_cache_t *inst, REQUEST *request, rl
 
        RDEBUG2("Merging cache entry into request");
 
-       if (c->packet && request->packet) {
+       if (c->packet) {
+               rad_assert(request->packet != NULL);
                rdebug_pair_list(L_DBG_LVL_2, request, c->packet, "&request:");
                radius_pairmove(request, &request->packet->vps, fr_pair_list_copy(request->packet, c->packet), false);
        }