Apply suggestions from code review

Co-authored-by: Remi Gacogne <github@coredump.fr>

diff --git a/pdns/histogram.hh b/pdns/histogram.hh
index 03cae4fc420539515e9c925f97a7e3c5cb11f8ec..beaaf795755f27b8dd91dfa7963d1d1ea5335eff 100644 (file)
--- a/pdns/histogram.hh
+++ b/pdns/histogram.hh
@@ -148,7 +148,7 @@ public:
 
 private:
   std::vector<B> d_buckets;
-  std::string d_name;
+  const std::string d_name;
   mutable SumType d_sum{0};
 
   std::vector<uint64_t> to125(uint64_t start, int num)

diff --git a/pdns/recursordist/docs/metrics.rst b/pdns/recursordist/docs/metrics.rst
index 88095a89b6cc5e33b6f5f78ee4f9075bb32340f9..ed98628a943be74a3b7f5967b8cfa1b196a357be 100644 (file)
--- a/pdns/recursordist/docs/metrics.rst
+++ b/pdns/recursordist/docs/metrics.rst
@@ -267,19 +267,19 @@ cpu-steal
 Stolen time, which is the time spent by the whole system in other operating systems when running in a virtualized environment, in units of USER_HZ.
 
 cumul-answers-le-x
-^^^^^^^^^^^^^^^
+^^^^^^^^^^^^^^^^^^
 Cumulative counts of answer times in buckets less or equal than x microseconds.
 These metrics include packet cache hits.
 These metrics are useful for Prometheus.
 
 
 cumul-auth4-answers-x
-^^^^^^^^^^^^^^^
+^^^^^^^^^^^^^^^^^^^^^
 Cumulative counts of answer times of authoritative servers over IPv4 in buckets less than x microseconds.
 These metrics are useful for Prometheus.
 
 cumul-auth6-answers-x
-^^^^^^^^^^^^^^^
+^^^^^^^^^^^^^^^^^^^^^
 Cumulative counts of answer times of authoritative servers over IPv6 in buckets less than x microseconds.
 These metrics are useful for Prometheus.