]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Make migration events mandatory
authorJiri Denemark <jdenemar@redhat.com>
Wed, 11 May 2022 13:03:30 +0000 (15:03 +0200)
committerJiri Denemark <jdenemar@redhat.com>
Thu, 12 May 2022 14:25:57 +0000 (16:25 +0200)
All QEMU versions we care about support migration events and we should
be able to enable the associated capability when connecting to the
monitor. Failure to do so is thus considered fatal now.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/qemu/qemu_migration_params.c

index ec288b9fa1a0504b196835f2da96b845af08d53e..26754f03f82da81b7c77063190d3cfd595b129b7 100644 (file)
@@ -1433,10 +1433,8 @@ qemuMigrationCapsCheck(virQEMUDriver *driver,
 
     qemuDomainObjExitMonitor(vm);
 
-    if (rc < 0) {
-        virResetLastError();
-        VIR_DEBUG("Cannot enable migration events");
-    }
+    if (rc < 0)
+        return -1;
 
     /* Migration events capability must always be enabled, clearing it from
      * migration capabilities bitmap makes sure it won't be touched anywhere