]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
Make sure mdadm -S returns correct error code
authorNeil Brown <neilb@suse.de>
Fri, 21 Oct 2005 06:13:04 +0000 (06:13 +0000)
committerNeil Brown <neilb@suse.de>
Fri, 21 Oct 2005 06:13:04 +0000 (06:13 +0000)
If a bad file names was given, exit status still 0.
If some devices couldn't be stopped for "mdadm -Ss"
exit status still 0.

Thanks: Daniel Hottinger <hotti@google.com>

Signed-off-by: Neil Brown <neilb@suse.de>
mdadm.c

diff --git a/mdadm.c b/mdadm.c
index bd29882c1b5fa2770fc49ef429ecbdf742c467c0..ad3d1517ddeedb6b65810d6a529055d49f4de82e 100644 (file)
--- a/mdadm.c
+++ b/mdadm.c
@@ -1059,6 +1059,7 @@ int main(int argc, char *argv[])
                                                        put_md_name(name);
                                                }
                                        } while (!last && err);
+                                       if (err) rv |= 1
                                } else {
                                        fprintf(stderr, Name ": No devices given.\n");
                                        exit(2);
@@ -1088,7 +1089,8 @@ int main(int argc, char *argv[])
                                                rv |= Manage_ro(dv->devname, mdfd, -1); break;
                                        }
                                        close(mdfd);
-                               }
+                               } else
+                                       rv |= 1;
                        }
                }
                break;