Fixed few findings from Coverity scan

In function cgroup_parse_rules() added missing check for getpwuid() result.
In cgroup_get_procs() added missing fclose() on file descriptor.
In load_list() added missing fclose() on file descriptor.

Signed-off-by: Peter Schiffer <pschiffe@redhat.com>
Signed-off-by: Jan Safranek <jsafrane@redhat.com>

diff --git a/src/api.c b/src/api.c
index d5022c2b791da002ba026b58cf78234893926f73..e443ad50192bf73b2080a6021e607546804eae43 100644 (file)
--- a/src/api.c
+++ b/src/api.c
@@ -637,6 +637,9 @@ static int cgroup_parse_rules(bool cache, uid_t muid,
                 */
                if (grp && muid != CGRULE_INVALID) {
                        pwd = getpwuid(muid);
+                       if (!pwd) {
+                               continue;
+                       }
                        for (i = 0; grp->gr_mem[i]; i++) {
                                if (!(strcmp(pwd->pw_name, grp->gr_mem[i])))
                                        matched = true;
@@ -3910,6 +3913,8 @@ int cgroup_get_procs(char *name, char *controller, pid_t **pids, int *size)
                }
        }
 
+       fclose(procs);
+
        *size = n;
 
        qsort(tmp_list, n, sizeof(pid_t), &pid_compare);

diff --git a/src/tools/cgsnapshot.c b/src/tools/cgsnapshot.c
index 30e7b6de33e17d54c517ba76d687ec483b0ae80e..404d54ad492e793258577fe9d7ee510cbe4d7e46 100644 (file)
--- a/src/tools/cgsnapshot.c
+++ b/src/tools/cgsnapshot.c
@@ -146,6 +146,8 @@ int load_list(char *filename, struct black_list_type **p_list)
                }
        }
 
+       fclose(fw);
+
        *p_list = start;
        return 0;