]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virStorageSourceParseBackingJSONUriCookies: Use g_strsplit instead of virStringSplitCount
authorPeter Krempa <pkrempa@redhat.com>
Tue, 23 Mar 2021 08:12:19 +0000 (09:12 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 12 Apr 2021 13:55:09 +0000 (15:55 +0200)
Count the elements after splitting the string.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/storage_file/storage_source_backingstore.c

index bac5a043e504d6b436bb2c4a476eeef9ed0cae5c..9a67d64fd64492eba1e4ba3d9abc959211756fe3 100644 (file)
@@ -483,7 +483,6 @@ virStorageSourceParseBackingJSONUriCookies(virStorageSourcePtr src,
 {
     const char *cookiestr;
     g_auto(GStrv) cookies = NULL;
-    size_t ncookies = 0;
     size_t i;
 
     if (!virJSONValueObjectHasKey(json, "cookie"))
@@ -496,13 +495,13 @@ virStorageSourceParseBackingJSONUriCookies(virStorageSourcePtr src,
         return -1;
     }
 
-    if (!(cookies = virStringSplitCount(cookiestr, ";", 0, &ncookies)))
+    if (!(cookies = g_strsplit(cookiestr, ";", 0)))
         return -1;
 
-    src->cookies = g_new0(virStorageNetCookieDefPtr, ncookies);
-    src->ncookies = ncookies;
+    src->ncookies = g_strv_length(cookies);
+    src->cookies = g_new0(virStorageNetCookieDefPtr, src->ncookies);
 
-    for (i = 0; i < ncookies; i++) {
+    for (i = 0; i < src->ncookies; i++) {
         char *cookiename = cookies[i];
         char *cookievalue;