]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: qcom: phy-qcom-snps-eusb2: Add missing write from init sequence
authorLuca Weiss <luca.weiss@fairphone.com>
Tue, 15 Jul 2025 07:29:36 +0000 (09:29 +0200)
committerVinod Koul <vkoul@kernel.org>
Tue, 22 Jul 2025 12:35:45 +0000 (18:05 +0530)
As per a commit from Qualcomm's downstream 6.1 kernel[0], the init
sequence is missing setting the CMN_CTRL_OVERRIDE_EN bit back to 0 at
the end, as per the 'latest' HPG revision (as of November 2023).

[0] https://git.codelinaro.org/clo/la/kernel/qcom/-/commit/b77774a89e3fda3246e09dd39e16e2ab43cd1329

Fixes: 80090810f5d3 ("phy: qcom: Add QCOM SNPS eUSB2 driver")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Link: https://lore.kernel.org/r/20250715-sm7635-eusb-phy-v3-3-6c3224085eb6@fairphone.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/phy-snps-eusb2.c

index 87f323e758d6712b02b5f921e37811c2358dddb1..cd41d8a9f2906e502615a22b8dffb86814ce1532 100644 (file)
@@ -437,6 +437,9 @@ static int qcom_snps_eusb2_hsphy_init(struct phy *p)
        snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL2,
                                    USB2_SUSPEND_N_SEL, 0);
 
+       snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG0,
+                                   CMN_CTRL_OVERRIDE_EN, 0);
+
        return 0;
 }