]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
perf stat: Fix affinity memory leaks on error path
authorIan Rogers <irogers@google.com>
Tue, 1 Oct 2024 05:23:24 +0000 (22:23 -0700)
committerNamhyung Kim <namhyung@kernel.org>
Wed, 2 Oct 2024 21:58:03 +0000 (14:58 -0700)
Missed cleanup when an error occurs.

Fixes: 49de179577e7 ("perf stat: No need to setup affinities when starting a workload")
Signed-off-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20241001052327.7052-2-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/builtin-stat.c

index 1521b6df26065ccfdce6ebdcf147b83855b94406..3e6b9f216e80234ee49422845ce27da396e26e87 100644 (file)
@@ -827,6 +827,7 @@ try_again_reset:
                }
        }
        affinity__cleanup(affinity);
+       affinity = NULL;
 
        evlist__for_each_entry(evsel_list, counter) {
                if (!counter->supported) {
@@ -965,6 +966,7 @@ err_out:
        if (forks)
                evlist__cancel_workload(evsel_list);
 
+       affinity__cleanup(affinity);
        return err;
 }