MIPS: CPS: Fix potential NULL pointer dereferences in cps_prepare_cpus()

Check the return values of kcalloc() and exit early to avoid potential
NULL pointer dereferences.

Compile-tested only.

Cc: stable@vger.kernel.org
Fixes: 75fa6a583882e ("MIPS: CPS: Introduce struct cluster_boot_config")
Fixes: 0856c143e1cd3 ("MIPS: CPS: Boot CPUs in secondary clusters")
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

diff --git a/arch/mips/kernel/smp-cps.c b/arch/mips/kernel/smp-cps.c
index e85bd087467e8caf0640ad247ee5f8eb65107591..cc26d56f3ab61a693b47e8bdfd791b52fda5d6e7 100644 (file)
--- a/arch/mips/kernel/smp-cps.c
+++ b/arch/mips/kernel/smp-cps.c
@@ -332,6 +332,8 @@ static void __init cps_prepare_cpus(unsigned int max_cpus)
        mips_cps_cluster_bootcfg = kcalloc(nclusters,
                                           sizeof(*mips_cps_cluster_bootcfg),
                                           GFP_KERNEL);
+       if (!mips_cps_cluster_bootcfg)
+               goto err_out;
 
        if (nclusters > 1)
                mips_cm_update_property();
@@ -348,6 +350,8 @@ static void __init cps_prepare_cpus(unsigned int max_cpus)
                mips_cps_cluster_bootcfg[cl].core_power =
                        kcalloc(BITS_TO_LONGS(ncores), sizeof(unsigned long),
                                GFP_KERNEL);
+               if (!mips_cps_cluster_bootcfg[cl].core_power)
+                       goto err_out;
 
                /* Allocate VPE boot configuration structs */
                for (c = 0; c < ncores; c++) {