]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
rtla/tests: Check -c/--cpus thread affinity
authorTomas Glozar <tglozar@redhat.com>
Thu, 23 Apr 2026 13:05:52 +0000 (15:05 +0200)
committerTomas Glozar <tglozar@redhat.com>
Mon, 18 May 2026 09:00:51 +0000 (11:00 +0200)
RTLA runtime tests verify the -c/--cpus options, but do not check
whether the correct affinity is actually applied.

Add a script named check-cpus.sh that retrieves the affinity of all
workload threads and use it to check the -c/--cpus option for both
osnoise and timerlat tools.

Also add missing -c/--cpus test for osnoise.

Reviewed-by: Wander Lairson Costa <wander@redhat.com>
Link: https://lore.kernel.org/r/20260423130558.882022-4-tglozar@redhat.com
Signed-off-by: Tomas Glozar <tglozar@redhat.com>
tools/tracing/rtla/tests/osnoise.t
tools/tracing/rtla/tests/scripts/check-cpus.sh [new file with mode: 0755]
tools/tracing/rtla/tests/timerlat.t

index ed6ff0cc33299b310ed400ca1930e1128e914273..5edffb23981b28140d5fcae012b223c56d5b3074 100644 (file)
@@ -18,6 +18,8 @@ check_top_q_hist "verify the --trace param" \
        "osnoise TOOL -s 30 -T 1 -t" 2 "Saving trace to osnoise_trace.txt"
 check "verify the --entries/-E param" \
        "osnoise hist -P F:1 -c 0 -r 900000 -d 10s -b 10 -E 25"
+check_top_q_hist "verify the -c/--cpus param" \
+       "osnoise TOOL -P F:1 -c 0 -r 900000 -d 10s -S 1 --on-threshold shell,command=tests/scripts/check-cpus.sh" 2 "^Affinity of threads: 0$"
 
 # Test setting default period by putting an absurdly high period
 # and stopping on threshold.
diff --git a/tools/tracing/rtla/tests/scripts/check-cpus.sh b/tools/tracing/rtla/tests/scripts/check-cpus.sh
new file mode 100755 (executable)
index 0000000..0b016d4
--- /dev/null
@@ -0,0 +1,9 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0
+. "$(dirname $0)/lib/get_workload_pids.sh"
+echo -n "Affinity of threads: "
+for pid in $(get_workload_pids)
+do
+    echo -n $(taskset -c -p $pid | cut -d ':' -f 2)
+done
+echo
index 765dffd9d42a8ff2657867094a1714435d7e684c..fb60022aaa649e538785ca0a70466720e21759de 100644 (file)
@@ -39,8 +39,8 @@ check "print the auto-analysis if hits the stop tracing condition" \
        "timerlat top --aa-only 5" 2
 check_top_hist "disable auto-analysis" \
        "timerlat TOOL -s 3 -T 10 -t --no-aa" 2
-check_top_hist "verify -c/--cpus" \
-       "timerlat TOOL -c 0 -d 10s"
+check_top_q_hist "verify -c/--cpus" \
+       "timerlat TOOL -c 0 -d 10s -T 1 --on-threshold shell,command=tests/scripts/check-cpus.sh" 2 "^Affinity of threads: 0$"
 
 # Actions tests
 check_top_q_hist "trace output through -t" \