Backing out patch from bug 108528 - failed to take i10n concerns into account

diff --git a/CGI.pl b/CGI.pl
index 06db6fe554cb449c480c0e3df1c7be36c2014537..bcd9a7f90042bffda9d27dbbb8ee72ac152a9be6 100644 (file)
--- a/CGI.pl
+++ b/CGI.pl
@@ -111,11 +111,10 @@ sub CheckFormField (\%$;\@) {
 sub CheckFormFieldDefined (\%$) {
     my ($formRef,                # a reference to the form to check (a hash)
         $fieldname,              # the fieldname to check
-        $info,                   # (optional) error message to give
        ) = @_;
 
     if (!defined $formRef->{$fieldname}) {
-        ThrowCodeError("undefined_field", { field => $fieldname, info => $info });
+        ThrowCodeError("undefined_field", { field => $fieldname });
     }
 }
 

diff --git a/process_bug.cgi b/process_bug.cgi
index d3155af3364a8d1ccb9a367b42f03aa3248d2316..5608c0528dd2eea216930b13d8113a493946166c 100755 (executable)
--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -842,15 +842,15 @@ if (defined $::FORM{newcc} || defined $::FORM{removecc} || defined $::FORM{massc
     }
 
     if ($cc_add) {
-        $cc_add =~ s/[\s,]+/ /g; # Change all delimiters to a single space
-        foreach my $person ( split(" ", $cc_add) ) {
+        $cc_add =~ s/^[\s,]+//; # Remove leading delimiters.
+        foreach my $person ( split(/[\s,]+/, $cc_add) ) {
             my $pid = DBNameToIdAndCheck($person);
             $cc_add{$pid} = $person;
         }
     }
     if ($cc_remove) {
-        $cc_remove =~ s/[\s,]+/ /g; # Change all delimiters to a single space
-        foreach my $person ( split(" ", $cc_remove) ) {
+        $cc_remove =~ s/^[\s,]+//; # Remove leading delimiters.
+        foreach my $person ( split(/[\s,]+/, $cc_remove) ) {
             my $pid = DBNameToIdAndCheck($person);
             $cc_remove{$pid} = $person;
         }

diff --git a/template/en/default/global/code-error.html.tmpl b/template/en/default/global/code-error.html.tmpl
index 458f55c559a3197cdd057b53dec2104018438860..73501672b9bb5a0e6d2fb50ec1cb76f937975fcf 100644 (file)
--- a/template/en/default/global/code-error.html.tmpl
+++ b/template/en/default/global/code-error.html.tmpl
@@ -208,12 +208,7 @@
      I was unable to retrieve your old password from the database.
 
   [% ELSIF error == "undefined_field" %]
-    [% field FILTER html %] was not defined; 
-    [% IF info %]
-      [% info FILTER html %]
-    [% ELSE %]
-      [% Param('browserbugmessage') %]
-    [% END %]
+    [% field FILTER html %] was not defined; [% Param('browserbugmessage') %]
 
   [% ELSIF error == "unknown_action" %]
     [% IF action %]