]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: ti: icss-iep: Fix incorrect type for return value in extts_enable()
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Tue, 5 Aug 2025 14:23:18 +0000 (07:23 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:28:14 +0000 (16:28 +0200)
[ Upstream commit 5f1d1d14db7dabce9c815e7d7cd351f8d58b8585 ]

The variable ret in icss_iep_extts_enable() was incorrectly declared
as u32, while the function returns int and may return negative error
codes. This will cause sign extension issues and incorrect error
propagation. Update ret to be int to fix error handling.

This change corrects the declaration to avoid potential type mismatch.

Fixes: c1e0230eeaab ("net: ti: icss-iep: Add IEP driver")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20250805142323.1949406-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/ti/icssg/icss_iep.c

index 8ed72c8b210f68a2c3117b4601938355ab89a882..e7306ed529226acb4f4d3b0395f7db2e29bb39d5 100644 (file)
@@ -638,7 +638,8 @@ exit:
 
 static int icss_iep_extts_enable(struct icss_iep *iep, u32 index, int on)
 {
-       u32 val, cap, ret = 0;
+       u32 val, cap;
+       int ret = 0;
 
        mutex_lock(&iep->ptp_clk_mutex);