Bug 122418 pt2 - obsoleting a patch from the create attachment screen gave

a taint error.

diff --git a/attachment.cgi b/attachment.cgi
index 368ad702e2c0c932619f9a4ec5944d6d6a891c9e..f58844835b485c0ce2436d734d44b909f56b0080 100755 (executable)
--- a/attachment.cgi
+++ b/attachment.cgi
@@ -314,7 +314,7 @@ sub validateObsolete
   # Make sure the attachment id is valid and the user has permissions to view
   # the bug to which it is attached.
   foreach my $attachid (@{$::MFORM{'obsolete'}}) {
-    $attachid =~ /^[1-9][0-9]*$/
+    detaint_natural($attachid)
       || DisplayError("The attachment number of one of the attachments 
            you wanted to obsolete is invalid.") 
         && exit;