]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
http2: do not set file flags for global txs
authorPhilippe Antoine <pantoine@oisf.net>
Tue, 15 Apr 2025 10:38:34 +0000 (12:38 +0200)
committerPhilippe Antoine <pantoine@oisf.net>
Mon, 7 Jul 2025 07:04:14 +0000 (09:04 +0200)
Global txs means here txs with stream id 0, used for connection control
messages.

(cherry picked from commit fa8d3a4ccb17f84ccc577069a941a589b6e3906c)

rust/src/http2/http2.rs

index 8aa21189a82d77dc018d962e04ab0e0869d6d92f..3994ce698a670922980dd49f94df0b951d54e5a0 100644 (file)
@@ -602,10 +602,7 @@ impl HTTP2State {
         self.tx_id += 1;
         tx.tx_id = self.tx_id;
         tx.state = HTTP2TransactionState::HTTP2StateGlobal;
-        tx.tx_data.update_file_flags(self.state_data.file_flags);
-        // TODO can this tx hold files?
-        tx.tx_data.file_tx = STREAM_TOSERVER|STREAM_TOCLIENT; // might hold files in both directions
-        tx.update_file_flags(tx.tx_data.file_flags);
+        // a global tx (stream id 0) does not hold files cf RFC 9113 section 5.1.1
         self.transactions.push_back(tx);
         return self.transactions.back_mut().unwrap();
     }