]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: chips-media: wave5: Fix gray color on screen
authorJackson.lee <jackson.lee@chipsnmedia.com>
Tue, 17 Dec 2024 04:51:22 +0000 (13:51 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 20 Apr 2025 08:15:38 +0000 (10:15 +0200)
commit 6bae4d5053da634eecb611118e7cd91a677a4bbf upstream.

When a decoder instance is created, the W5_CMD_ERR_CONCEAL register
should be initialized to 0. Otherwise, gray color is occasionally
displayed on the screen while decoding.

Fixes: 45d1a2b93277 ("media: chips-media: wave5: Add vpuapi layer")
Cc: stable@vger.kernel.org
Signed-off-by: Jackson.lee <jackson.lee@chipsnmedia.com>
Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/platform/chips-media/wave5/wave5-hw.c

index c89aafabc742133b0978c55617e354492ece91c2..710311d851138652f56774cf28f33337f9e7471d 100644 (file)
@@ -576,7 +576,7 @@ int wave5_vpu_build_up_dec_param(struct vpu_instance *inst,
                vpu_write_reg(inst->dev, W5_CMD_NUM_CQ_DEPTH_M1,
                              WAVE521_COMMAND_QUEUE_DEPTH - 1);
        }
-
+       vpu_write_reg(inst->dev, W5_CMD_ERR_CONCEAL, 0);
        ret = send_firmware_command(inst, W5_CREATE_INSTANCE, true, NULL, NULL);
        if (ret) {
                wave5_vdi_free_dma_memory(vpu_dev, &p_dec_info->vb_work);