]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Check return code of BIO_ADDR_rawaddress
authorNorbert Pocs <norbertp@openssl.org>
Sun, 5 Oct 2025 07:39:22 +0000 (09:39 +0200)
committerNeil Horman <nhorman@openssl.org>
Tue, 7 Oct 2025 16:30:09 +0000 (12:30 -0400)
Fixes coverity issue: https://scan5.scan.coverity.com/#/project-view/64471/10222?selectedIssue=1666584
Thank you for the report!

Signed-off-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from https://github.com/openssl/openssl/pull/28751)

apps/lib/s_cb.c

index 496cb3c6f1684f78f4eb4debf8884c31a679c752..b567b179b685f01d1b107b9095b50debc8fe0d1e 100644 (file)
@@ -894,7 +894,8 @@ int generate_stateless_cookie_callback(SSL *ssl, unsigned char *cookie,
     buffer = app_malloc(length, "cookie generate buffer");
 
     memcpy(buffer, &port, sizeof(port));
-    BIO_ADDR_rawaddress(peer, buffer + sizeof(port), NULL);
+    if (!BIO_ADDR_rawaddress(peer, buffer + sizeof(port), NULL))
+        goto end;
 
     if (EVP_Q_mac(NULL, "HMAC", NULL, "SHA1", NULL,
                   cookie_secret, COOKIE_SECRET_LENGTH, buffer, length,