]> git.ipfire.org Git - thirdparty/kmod.git/commitdiff
modinfo: fixup type-only parm print format
authorEmil Velikov <emil.l.velikov@gmail.com>
Tue, 14 Jul 2026 18:35:37 +0000 (19:35 +0100)
committerLucas De Marchi <demarchi@kernel.org>
Thu, 6 Aug 2026 01:35:44 +0000 (20:35 -0500)
The generic (full) expression is:
 - "$name:$parm ($type)"

Although currently, if no $parm is available and --field isn't used we
instead print:
 - "$name:$type"

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/451
Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
tools/modinfo.c

index 8ec24a978fed52a68fb5283d6868532de38cb111..55e97da3c7b6e209d9480baf8e1d8b380f88a729 100644 (file)
@@ -229,7 +229,7 @@ static int modinfo_do(struct kmod_module *mod)
                params = p->next;
 
                if (p->param == NULL)
-                       printf("%-16s%.*s:%.*s%c", "parm:", p->namelen, p->name,
+                       printf("%-16s%.*s: (%.*s)%c", "parm:", p->namelen, p->name,
                               p->typelen, p->type, separator);
                else if (p->type != NULL)
                        printf("%-16s%.*s:%.*s (%.*s)%c", "parm:", p->namelen, p->name,