Ensure that SDP parsing does not ignore the last line of the SDP.

(closes issue #16268)
Reported by: sgimeno

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@230772 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 368de4b58a4a1b40e4eb5c23414bc853277a19cc..52ce80a6d405971950ba2718f695d93f02c0414e 100644 (file)
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -4367,7 +4367,7 @@ static const char *get_sdp_iterate(int *start, struct sip_request *req, const ch
 {
        int len = strlen(name);
 
-       while (*start < req->sdp_end) {
+       while (*start <= req->sdp_end) {
                const char *r = get_body_by_line(req->line[(*start)++], name, len);
                if (r[0] != '\0')
                        return r;
@@ -4377,15 +4377,16 @@ static const char *get_sdp_iterate(int *start, struct sip_request *req, const ch
 }
 
 /*! \brief Fetches the next valid SDP line between the 'start' line
- * and the 'stop' line. Returns the type ('a', 'c', ...) and 
- * matching line in reference 'start' is updated with the next line number.
+ * and the 'stop' line (*excluding* the 'stop' line). Returns the type
+ * ('a', 'c', ...) and matching line in reference 'start' is updated with the
+ * next line number.
  */
 static char get_sdp_line(int *start, int stop, struct sip_request *req, const char **value)
 {
        char type = '\0';
        const char *line = NULL;
 
-       if (stop > req->sdp_end || stop < req->sdp_start) stop = req->sdp_end;
+       if (stop > req->sdp_end || stop < req->sdp_start) stop = req->sdp_end + 1;
 
        while (*start < stop) {
                line = req->line[(*start)++];