]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
Revert "test: skip one test case when running on coverage"
authorYu Watanabe <watanabe.yu+github@gmail.com>
Wed, 16 Jul 2025 01:46:06 +0000 (10:46 +0900)
committerLuca Boccassi <luca.boccassi@gmail.com>
Wed, 16 Jul 2025 09:50:36 +0000 (10:50 +0100)
This reverts commit 2cc6c651ee2df408b2cc72c000d7f7f08c8932ac.

The issue was fixed by b955051244ce72ec5879d49e76dbf2b5ea0edeee.

Closes #38163.

test/units/TEST-13-NSPAWN.nspawn.sh

index 64bd485b4215ac9f45b30e395d58550ead69bdfe..b27bfbacf741a39ee35b51fccc50bfc5addec444 100755 (executable)
@@ -1422,18 +1422,7 @@ testcase_unpriv_dir() {
     # Use an image owned by the foreign UID range first via direct mapping, and than via the managed uid logic
     systemd-dissect --shift "$root" foreign
     assert_eq "$(systemd-nspawn --pipe --register=no -D "$root" --private-users=pick --private-users-ownership=foreign bash -c 'echo foobar')" "foobar"
-    # FIXME:
-    # Since 90fa161b5ba29d58953e9f08ddca49121b51efe6, --bind= or Bind= settings for coverage directory does
-    # not work with managed mode:
-    # ========
-    # [  158.105361] systemd-nspawn[3718]: Failed to open tree and set mount attributes: Operation not permitted
-    # [  158.105364] systemd-nspawn[3718]: Failed to clone /coverage: Operation not permitted
-    # [  158.118655] systemd-nspawn[3707]: (sd-namespace) failed with exit status 1.
-    # ========
-    # Let's tentatively skip the test case when running on coverage.
-    if [[ -z "${COVERAGE_BUILD_DIR:-}" ]]; then
-        assert_eq "$(systemd-nspawn --pipe --register=no -D "$root" --private-users=managed --private-network bash -c 'echo foobar')" "foobar"
-    fi
+    assert_eq "$(systemd-nspawn --pipe --register=no -D "$root" --private-users=managed --private-network bash -c 'echo foobar')" "foobar"
 
     # Test unprivileged operation
     chown testuser:testuser "$root/.."