]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
smbd: Simply return status instead of special-casing errors
authorVolker Lendecke <vl@samba.org>
Tue, 20 Jan 2026 11:51:29 +0000 (12:51 +0100)
committerAnoop C S <anoopcs@samba.org>
Sun, 15 Feb 2026 10:42:33 +0000 (10:42 +0000)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
source3/smbd/smb2_server.c

index 1b74e52559d5c09f638daa5c24f2995dc1c38384..c5e910204a0593f08d7aa1a4e4aefcc0fe5ca216 100644 (file)
@@ -5008,11 +5008,7 @@ static NTSTATUS smbd_smb2_flush_send_queue(struct smbXsrv_connection *xconn)
         */
 
        status = smbd_smb2_request_next_incoming(xconn);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
-
-       return NT_STATUS_OK;
+       return status;
 }
 
 static NTSTATUS smbd_smb2_advance_incoming(struct smbXsrv_connection *xconn, size_t n)
@@ -5208,11 +5204,7 @@ got_full:
        }
 
        status = smbd_smb2_request_next_incoming(xconn);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
-
-       return NT_STATUS_OK;
+       return status;
 }
 
 static NTSTATUS smbd_smb2_io_handler(struct smbXsrv_connection *xconn,
@@ -5315,11 +5307,8 @@ again:
                 */
                goto again;
        }
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
 
-       return NT_STATUS_OK;
+       return status;
 }
 
 static void smbd_smb2_connection_handler(struct tevent_context *ev,