]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
imsm: fix tpv drvies check in add_to_super
authorBlazej Kucman <blazej.kucman@intel.com>
Wed, 20 Nov 2024 15:50:25 +0000 (16:50 +0100)
committerMariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Wed, 27 Nov 2024 08:10:53 +0000 (09:10 +0100)
Before the mentioned patch, the check to verify if IMSM on current
platform supports a use of TPV (other than Intel) disk, was only performed
for non-Intel disks, after it is performed for all. This change causes
inability to use any disk when platform does not support TPV drives,
attempt results in the following error.

mdadm:  Platform configuration does not support non-Intel NVMe drives.
        Please refer to Intel(R) RSTe/VROC user guide.

This change restores the check if the disk is non-Intel.

Fixes: 734e7db4dfc5 ("imsm: Remove warning and refactor add_to_super_imsm code")
Signed-off-by: Blazej Kucman <blazej.kucman@intel.com>
super-intel.c

index 9c464945d09caa5fc5b33f9c83c5e075690ee2f7..7e3c5f2b70479b5f708a912d700a318412925622 100644 (file)
@@ -6121,7 +6121,8 @@ static int add_to_super_imsm(struct supertype *st, mdu_disk_info_t *dk,
                        pr_err("%s controller supports Multi-Path I/O, Intel (R) VROC does not support multipathing\n",
                               basename(cntrl_path));
 
-               if (super->orom && !imsm_orom_has_tpv_support(super->orom)) {
+               if (super->orom && devpath_to_vendor(pci_dev_path) != 0x8086 &&
+                   !imsm_orom_has_tpv_support(super->orom)) {
                        pr_err("\tPlatform configuration does not support non-Intel NVMe drives.\n"
                               "\tPlease refer to Intel(R) RSTe/VROC user guide.\n");
                        goto error;