]> git.ipfire.org Git - thirdparty/openssh-portable.git/commitdiff
upstream: Plug mem leak on globbed ls error path.
authordtucker@openbsd.org <dtucker@openbsd.org>
Mon, 27 Feb 2023 22:12:40 +0000 (22:12 +0000)
committerDarren Tucker <dtucker@dtucker.net>
Tue, 28 Feb 2023 08:51:21 +0000 (19:51 +1100)
 Spotted by Coverity, ok deraadt@

OpenBSD-Commit-ID: de28476025db29820a9a2e56e98b964d8a02861c

sftp.c

diff --git a/sftp.c b/sftp.c
index b3616c15cd0948bd19208c801a1108af093a84ef..deb975cbad51211b5070c5ec28f86cae945657b0 100644 (file)
--- a/sftp.c
+++ b/sftp.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: sftp.c,v 1.225 2023/01/05 05:49:13 djm Exp $ */
+/* $OpenBSD: sftp.c,v 1.226 2023/02/27 22:12:40 dtucker Exp $ */
 /*
  * Copyright (c) 2001-2004 Damien Miller <djm@openbsd.org>
  *
@@ -1030,6 +1030,7 @@ do_globbed_ls(struct sftp_conn *conn, const char *path,
                if (lflag & LS_LONG_VIEW) {
                        if (g.gl_statv[i] == NULL) {
                                error("no stat information for %s", fname);
+                               free(fname);
                                continue;
                        }
                        lname = ls_file(fname, g.gl_statv[i], 1,