Remove unused arguments in ieee802_11_parse_link_assoc_req()

The unparsed buffer of all IEs was not actually used at all in
ieee802_11_parse_link_assoc_req().

Signed-off-by: Adil Saeed Musthafa <quic_adilm@quicinc.com>

diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c
index 3d5674d2fe38e1d0c0f9d0fac4d361e9f1e116b1..d26b9c546f2666fbf5cbbf8cc795fe5c29eecf31 100644 (file)
--- a/src/ap/ieee802_11.c
+++ b/src/ap/ieee802_11.c
@@ -4573,9 +4573,8 @@ static int ieee80211_ml_process_link(struct hostapd_data *hapd,
        if (!mlbuf)
                goto out;
 
-       if (ieee802_11_parse_link_assoc_req(ies, ies_len, &elems, mlbuf,
-                                           hapd->mld_link_id, true) ==
-           ParseFailed) {
+       if (ieee802_11_parse_link_assoc_req(&elems, mlbuf, hapd->mld_link_id,
+                                           true) == ParseFailed) {
                wpa_printf(MSG_DEBUG,
                           "MLD: link: Failed to parse association request Multi-Link element");
                status = WLAN_STATUS_UNSPECIFIED_FAILURE;

diff --git a/src/common/ieee802_11_common.c b/src/common/ieee802_11_common.c
index 56d556980e17988d5fff47617653f629ac104404..4a35479fc7b5d111528dbad9295dc3034a477fbc 100644 (file)
--- a/src/common/ieee802_11_common.c
+++ b/src/common/ieee802_11_common.c
@@ -985,14 +985,14 @@ void ieee802_11_elems_clear_ext_ids(struct ieee802_11_elems *elems,
 }
 
 
-ParseRes ieee802_11_parse_link_assoc_req(const u8 *start, size_t len,
-                                        struct ieee802_11_elems *elems,
+ParseRes ieee802_11_parse_link_assoc_req(struct ieee802_11_elems *elems,
                                         struct wpabuf *mlbuf,
                                         u8 link_id, bool show_errors)
 {
        const struct ieee80211_eht_ml *ml;
        const u8 *pos;
        ParseRes res = ParseFailed;
+       size_t len;
 
        pos = wpabuf_head(mlbuf);
        len = wpabuf_len(mlbuf);

diff --git a/src/common/ieee802_11_common.h b/src/common/ieee802_11_common.h
index b8cecab0d1e726d5dc8ab73315ab1f70adf47109..b98617ea637c3993eeaa0eaf2cf5034e0e3f788c 100644 (file)
--- a/src/common/ieee802_11_common.h
+++ b/src/common/ieee802_11_common.h
@@ -210,8 +210,7 @@ void ieee802_11_elems_clear_ids(struct ieee802_11_elems *elems,
                                const u8 *ids, size_t num);
 void ieee802_11_elems_clear_ext_ids(struct ieee802_11_elems *elems,
                                    const u8 *ids, size_t num);
-ParseRes ieee802_11_parse_link_assoc_req(const u8 *start, size_t len,
-                                        struct ieee802_11_elems *elems,
+ParseRes ieee802_11_parse_link_assoc_req(struct ieee802_11_elems *elems,
                                         struct wpabuf *mlbuf,
                                         u8 link_id, bool show_errors);
 int ieee802_11_ie_count(const u8 *ies, size_t ies_len);