mid+contenthash: eliminate needless local variable captures

It's possible in theory that Perl could be smarter and free
memory a tad sooner this way.  Regardless, fewer lines of code
is easier-to-navigate/read and can save optree size and reduce
parsing times.

diff --git a/lib/PublicInbox/ContentHash.pm b/lib/PublicInbox/ContentHash.pm
index d3ff146aa96e91ef3ada23c29689de0a33f6b2e0..a4f6196f8f686ae6096913f4ee305979dad74687 100644 (file)
--- a/lib/PublicInbox/ContentHash.pm
+++ b/lib/PublicInbox/ContentHash.pm
@@ -76,8 +76,7 @@ sub content_digest ($;$) {
                last;
        }
        foreach my $h (qw(Subject Date)) {
-               my @v = $eml->header($h);
-               foreach my $v (@v) {
+               for my $v ($eml->header($h)) {
                        utf8::encode($v);
                        $dig->add("$h\0$v\0");
                }
@@ -86,8 +85,7 @@ sub content_digest ($;$) {
        # not in the original message.  For the purposes of deduplication,
        # do not take it into account:
        foreach my $h (qw(To Cc)) {
-               my @v = $eml->header($h);
-               digest_addr($dig, $h, $_) foreach @v;
+               digest_addr($dig, $h, $_) for ($eml->header($h));
        }
        msg_iter($eml, \&content_dig_i, $dig);
        $dig;

diff --git a/lib/PublicInbox/MID.pm b/lib/PublicInbox/MID.pm
index 4819cc256f575f7463ddf030569ef07c8ae6c6a4..b1ae9939e92d6e430938aecc101b04f718248c00 100644 (file)
--- a/lib/PublicInbox/MID.pm
+++ b/lib/PublicInbox/MID.pm
@@ -92,8 +92,7 @@ sub references ($) {
        my ($hdr) = @_;
        my @mids;
        foreach my $f (qw(References In-Reply-To)) {
-               my @v = $hdr->header_raw($f);
-               foreach my $v (@v) {
+               for my $v ($hdr->header_raw($f)) {
                        push(@mids, ($v =~ /$MID_EXTRACT/g));
                }
        }
@@ -104,8 +103,7 @@ sub references ($) {
        my %addr = ( y => 1, n => 1 );
 
        foreach my $f (qw(To From Cc)) {
-               my @v = $hdr->header_raw($f);
-               foreach my $v (@v) {
+               for my $v ($hdr->header_raw($f)) {
                        $addr{$_} = 1 for (PublicInbox::Address::emails($v));
                }
        }