]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iommu: vsi: avoid -Wformat-security warning
authorArnd Bergmann <arnd@arndb.de>
Tue, 19 May 2026 20:36:51 +0000 (22:36 +0200)
committerJoerg Roedel <joerg.roedel@amd.com>
Thu, 28 May 2026 07:29:43 +0000 (09:29 +0200)
When -Wformat-security is enabled, it catches a call to
iommu_device_sysfs_add() that passes a string variable in
place of a format:

drivers/iommu/vsi-iommu.c: In function 'vsi_iommu_probe':
drivers/iommu/vsi-iommu.c:717:9: error: format not a string literal and no format arguments [-Werror=format-security]
  717 |         err = iommu_device_sysfs_add(&iommu->iommu, dev, NULL, dev_name(dev));
      |         ^~~

Pass this indirectly using "%s" as the format instead.

Fixes: 917ace84b770 ("iommu: Add verisilicon IOMMU driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
drivers/iommu/vsi-iommu.c

index 5d0721bd2c7af84755fb284da423b9f13eb10339..23913720d4840ab6b7700f6388dc5b2e4afd7781 100644 (file)
@@ -714,7 +714,8 @@ static int vsi_iommu_probe(struct platform_device *pdev)
        pm_runtime_use_autosuspend(dev);
        pm_runtime_enable(dev);
 
-       err = iommu_device_sysfs_add(&iommu->iommu, dev, NULL, dev_name(dev));
+       err = iommu_device_sysfs_add(&iommu->iommu, dev, NULL, "%s",
+                                    dev_name(dev));
        if (err)
                goto err_runtime_disable;