Patch by holger@holger.om.org (Holger Schurig) -- several cleanups.

diff --git a/CGI.pl b/CGI.pl
index c12ce8e5e7c83078700e57aa65b66daf112c1ac5..0d9762b222afb3e49ac8a0a077cc6dce6ec8d86d 100644 (file)
--- a/CGI.pl
+++ b/CGI.pl
@@ -29,11 +29,9 @@ require 'globals.pl';
 
 sub GeneratePersonInput {
     my ($field, $required, $def_value, $extraJavaScript) = (@_);
-    if (!defined $extraJavaScript) {
-        $extraJavaScript = "";
-    }
+    $extraJavaScript ||= "";
     if ($extraJavaScript ne "") {
-        $extraJavaScript = "onChange=\" $extraJavaScript \"";
+        $extraJavaScript = "onChange=\"$extraJavaScript\"";
     }
     return "<INPUT NAME=\"$field\" SIZE=32 $extraJavaScript VALUE=\"$def_value\">";
 }

diff --git a/buglist.cgi b/buglist.cgi
index ee4aa39fd3ca8592613f0ca0b2df1ef4608e03ab..8d3182200dd40d91c1c722d3340ac764544094a7 100755 (executable)
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -546,14 +546,13 @@ while (@row = FetchSQLData()) {
                 next;
             }
             my $value = shift @row;
-            my $nowrap = "";
 
             if ($::needquote{$c}) {
                 $value = html_quote($value);
             } else {
                 $value = "<nobr>$value</nobr>";
             }
-            pnl "<td $nowrap>$value";
+            pnl "<td>$value";
         }
         if ($dotweak) {
             my $value = shift @row;

diff --git a/query.cgi b/query.cgi
index bee45e9f410aacd6f1988df73453683e07a16b11..5f8d362149b6be52d4fef22ef9818b5815715e5b 100755 (executable)
--- a/query.cgi
+++ b/query.cgi
@@ -57,7 +57,7 @@ if (!defined $::buffer || $::buffer eq "") {
     $::buffer = $::COOKIE{"DEFAULTQUERY"};
 }
 
-my %default;
+use vars qw(%default);
 my %type;
 
 foreach my $name ("bug_status", "resolution", "assigned_to", "rep_platform",

diff --git a/reports.cgi b/reports.cgi
index c7a22fcd32d80a4bca67b4eb86464ba07bfcc7cd..21cfd780e3792651275cdabc0d448c42237a3e3f 100755 (executable)
--- a/reports.cgi
+++ b/reports.cgi
@@ -261,6 +261,9 @@ FIN
        # start painting report #
        #########################
 
+        $bugs_status{'NEW'}      ||= '0';
+        $bugs_status{'ASSIGNED'} ||= '0';
+        $bugs_status{'REOPENED'} ||= '0';
        print <<FIN;
 <h1>$quip</h1>
 <table border=1 cellpadding=5>