]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
add test for dnssec=false
authorPeter van Dijk <peter.van.dijk@powerdns.com>
Tue, 5 Nov 2019 09:32:48 +0000 (10:32 +0100)
committerPeter van Dijk <peter.van.dijk@powerdns.com>
Tue, 5 Nov 2019 09:43:55 +0000 (10:43 +0100)
regression-tests.api/test_Zones.py

index 03fd58646d147556e1f6004bc632411d5f69bf66..c2e51939e5062805ad04da48c2cb2845f1452094 100644 (file)
@@ -49,8 +49,11 @@ def eq_zone_rrsets(rrsets, expected):
 
 class Zones(ApiTestCase):
 
-    def test_list_zones(self):
-        r = self.session.get(self.url("/api/v1/servers/localhost/zones"))
+    def _test_list_zones(self, dnssec=True):
+        path = "/api/v1/servers/localhost/zones"
+        if not dnssec:
+            path = path + "?dnssec=false"
+        r = self.session.get(self.url(path))
         self.assert_success_json(r)
         domains = r.json()
         example_com = [domain for domain in domains if domain['name'] in ('example.com', 'example.com.')]
@@ -59,13 +62,22 @@ class Zones(ApiTestCase):
         print(example_com)
         required_fields = ['id', 'url', 'name', 'kind']
         if is_auth():
-            required_fields = required_fields + ['masters', 'last_check', 'notified_serial', 'edited_serial', 'serial', 'account']
+            required_fields = required_fields + ['masters', 'last_check', 'notified_serial', 'serial', 'account']
+            if dnssec:
+                required_fields = required_fields = ['dnssec', 'edited_serial']
             self.assertNotEquals(example_com['serial'], 0)
         elif is_recursor():
             required_fields = required_fields + ['recursion_desired', 'servers']
         for field in required_fields:
             self.assertIn(field, example_com)
+        if not dnssec:
+            self.assertNotIn('dnssec', example_com)
+
+    def test_list_zones_with_dnssec(self):
+        self._test_list_zones(True)
 
+    def test_list_zones_without_dnssec(self):
+        self._test_list_zones(False)
 
 class AuthZonesHelperMixin(object):
     def create_zone(self, name=None, **kwargs):