]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
nvmet: exit debugfs after discovery subsystem exits
authorMohamed Khalfella <mkhalfella@purestorage.com>
Thu, 7 Aug 2025 05:35:07 +0000 (22:35 -0700)
committerJens Axboe <axboe@kernel.dk>
Thu, 7 Aug 2025 12:27:58 +0000 (06:27 -0600)
Commit 528589947c180 ("nvmet: initialize discovery subsys after debugfs
is initialized") changed nvmet_init() to initialize nvme discovery after
"nvmet" debugfs directory is initialized. The change broke nvmet_exit()
because discovery subsystem now depends on debugfs. Debugfs should be
destroyed after discovery subsystem. Fix nvmet_exit() to do that.

Reported-by: Yi Zhang <yi.zhang@redhat.com>
Closes: https://lore.kernel.org/all/CAHj4cs96AfFQpyDKF_MdfJsnOEo=2V7dQgqjFv+k3t7H-=yGhA@mail.gmail.com/
Fixes: 528589947c180 ("nvmet: initialize discovery subsys after debugfs is initialized")
Signed-off-by: Mohamed Khalfella <mkhalfella@purestorage.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Link: https://lore.kernel.org/r/20250807053507.2794335-1-mkhalfella@purestorage.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/nvme/target/core.c

index 83f3d2f8ef2d046be454c5e5bd8024d097007b54..0dd7bd99afa327442697902f44e7a3082837f311 100644 (file)
@@ -1992,8 +1992,8 @@ out_destroy_bvec_cache:
 static void __exit nvmet_exit(void)
 {
        nvmet_exit_configfs();
-       nvmet_exit_debugfs();
        nvmet_exit_discovery();
+       nvmet_exit_debugfs();
        ida_destroy(&cntlid_ida);
        destroy_workqueue(nvmet_wq);
        destroy_workqueue(buffered_io_wq);