]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Fix RADIUS helper resource leak
authorAmos Jeffries <squid3@treenet.co.nz>
Fri, 17 Jun 2011 13:06:12 +0000 (07:06 -0600)
committerAmos Jeffries <squid3@treenet.co.nz>
Fri, 17 Jun 2011 13:06:12 +0000 (07:06 -0600)
cppcheck detected the config file was never closed/released. This could
prevent the helper shutting down cleanly.

helpers/basic_auth/squid_radius_auth/squid_rad_auth.c

index 20ab75c8e0dce29d7c3ba320b2484bee9df8aca7..ea4c0686f76bcf1ad07261fc4f927ed424a2afa2 100644 (file)
@@ -263,6 +263,7 @@ rad_auth_config(const char *cfname)
         if (!memcmp(line, "port", 4))
             sscanf(line, "port %s", svc_name);
     }
+    fclose(cf);
     if (srv && crt)
         return 0;
     return -1;