]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Revert "nouveau/gsp: cleanup IS_ERR_OR_NULL in rpc_rd"
authorLyude Paul <lyude@redhat.com>
Thu, 28 May 2026 19:27:18 +0000 (15:27 -0400)
committerDanilo Krummrich <dakr@kernel.org>
Thu, 28 May 2026 20:49:53 +0000 (22:49 +0200)
This is probably much too risky. See the discussion here:

  https://lists.freedesktop.org/archives/dri-devel/2026-May/570353.html

This reverts commit 47f15f6cf068c14d1a5054066c445bee23f6047e.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Timur Tabi <ttabi@nvidia.com>
Link: https://patch.msgid.link/20260528192847.4077458-5-lyude@redhat.com
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
drivers/gpu/drm/nouveau/include/nvkm/subdev/gsp.h

index d771134fa41075c90058ae4079a386b611be75f8..ab2bd88eebce58df705441669d154b9daf959ede 100644 (file)
@@ -293,7 +293,7 @@ nvkm_gsp_rpc_rd(struct nvkm_gsp *gsp, u32 fn, u32 argc)
 {
        void *argv = nvkm_gsp_rpc_get(gsp, fn, argc);
 
-       if (IS_ERR(argv))
+       if (IS_ERR_OR_NULL(argv))
                return argv;
 
        return nvkm_gsp_rpc_push(gsp, argv, NVKM_GSP_RPC_REPLY_RECV, argc);