Extend info argument updates for non-ntorv3 cases

diff --git a/src/feature/hs/hs_common.c b/src/feature/hs/hs_common.c
index 38c8bf2912c86572062ab93485e8a76a22d9a86d..3036ce271013cf9b1b5ce7c03a8021f2fd36aabc 100644 (file)
--- a/src/feature/hs/hs_common.c
+++ b/src/feature/hs/hs_common.c
@@ -1698,7 +1698,7 @@ hs_get_extend_info_from_lspecs(const smartlist_t *lspecs,
                             function that needs to initialize congestion
                             control structures based on what the client says.
                          */
-                         NULL);
+                         NULL, false);
  done:
   return info;
 }

diff --git a/src/feature/hs/hs_service.c b/src/feature/hs/hs_service.c
index 9b7b5901404498d1b4122c58685f5d9d231d1520..2b3699422a95e44f0d51321ed2a09ef7e9de2938 100644 (file)
--- a/src/feature/hs/hs_service.c
+++ b/src/feature/hs/hs_service.c
@@ -714,7 +714,7 @@ get_extend_info_from_intro_point(const hs_service_intro_point_t *ip,
 
   /* In the case of a direct connection (single onion service), it is possible
    * our firewall policy won't allow it so this can return a NULL value. */
-  info = extend_info_from_node(node, direct_conn);
+  info = extend_info_from_node(node, direct_conn, false);
 
  end:
   return info;

diff --git a/src/feature/relay/circuitbuild_relay.c b/src/feature/relay/circuitbuild_relay.c
index af3b488ae1c283c806a6b532e25ae1b292c430aa..5b1609a1af7196e9638c6764879038f600545cea 100644 (file)
--- a/src/feature/relay/circuitbuild_relay.c
+++ b/src/feature/relay/circuitbuild_relay.c
@@ -393,7 +393,8 @@ circuit_open_connection_for_extend(const struct extend_cell_t *ec,
                                 NULL, /*curve25519_key*/
                                 &chosen_ap->addr,
                                 chosen_ap->port,
-                                NULL /* protover summary */);
+                                NULL /* protover summary */,
+                                false);
 
   circ->n_chan_create_cell = tor_memdup(&ec->create_cell,
                                         sizeof(ec->create_cell));

diff --git a/src/feature/relay/relay_find_addr.c b/src/feature/relay/relay_find_addr.c
index 33a50ce3c35761a48637c1eb4b0dc3edfdc53253..f4f9d408238445fe1f0aa8946de01296804a7c1e 100644 (file)
--- a/src/feature/relay/relay_find_addr.c
+++ b/src/feature/relay/relay_find_addr.c
@@ -221,7 +221,7 @@ relay_addr_learn_from_dirauth(void)
                            "learn for now our address from them.");
       return;
     }
-    extend_info_t *ei = extend_info_from_node(node, 1);
+    extend_info_t *ei = extend_info_from_node(node, 1, false);
     if (BUG(!ei)) {
       return;
     }

diff --git a/src/feature/relay/selftest.c b/src/feature/relay/selftest.c
index d52fea3c11a8f2a29d6c2037598665fb2def903c..399b6bca6e5fbe253bb2bf6c08c82c01f2d655fd 100644 (file)
--- a/src/feature/relay/selftest.c
+++ b/src/feature/relay/selftest.c
@@ -229,7 +229,9 @@ extend_info_from_router(const routerinfo_t *r, int family)
                          ed_id_key,
                          rsa_pubkey, r->onion_curve25519_pkey,
                          &ap.addr, ap.port,
-                         NULL /* should self-tests use ntor3? */);
+                         /* TODO-324: Should self-test circuits use
+                          * congestion control? */
+                         NULL, false);
   crypto_pk_free(rsa_pubkey);
   return info;
 }

diff --git a/src/test/test_circuitpadding.c b/src/test/test_circuitpadding.c
index 5dc5fc5201aeff0281010356c34be930283cd805..63b7136a11d98f9d37a7d5ffa87328dffca17a63 100644 (file)
--- a/src/test/test_circuitpadding.c
+++ b/src/test/test_circuitpadding.c
@@ -1609,7 +1609,7 @@ simulate_single_hop_extend(circuit_t *client, circuit_t *mid_relay,
   hop->extend_info = extend_info_new(
           padding ? "padding" : "non-padding",
           digest, NULL, NULL, NULL,
-          &addr, padding, NULL);
+          &addr, padding, NULL, false);
 
   cpath_init_circuit_crypto(hop, whatevs_key, sizeof(whatevs_key), 0, 0);
 

diff --git a/src/test/test_hs_client.c b/src/test/test_hs_client.c
index 3d842382494d3d8f78d15d7206fdc3f8d9dd347a..0fe71ed7bd40afeb79ee34daa1df0501031ec5d1 100644 (file)
--- a/src/test/test_hs_client.c
+++ b/src/test/test_hs_client.c
@@ -1186,7 +1186,7 @@ test_socks_hs_errors(void *arg)
   /* Code path will log this exit so build it. */
   ocirc->build_state->chosen_exit = extend_info_new("TestNickname", digest,
                                                     NULL, NULL, NULL, &addr,
-                                                    4242, NULL);
+                                                    4242, NULL, false);
   /* Attach socks connection to this rendezvous circuit. */
   ocirc->p_streams = ENTRY_TO_EDGE_CONN(socks_conn);
   /* Trigger the rendezvous failure. Timeout the circuit and free. */
@@ -1281,7 +1281,7 @@ test_close_intro_circuit_failure(void *arg)
   /* Code path will log this exit so build it. */
   ocirc->build_state->chosen_exit = extend_info_new("TestNickname", digest,
                                                     NULL, NULL, NULL, &addr,
-                                                    4242, NULL);
+                                                    4242, NULL, false);
   ed25519_pubkey_copy(&ocirc->hs_ident->intro_auth_pk, &intro_kp.pubkey);
 
   /* We'll make for close the circuit for a timeout failure. It should _NOT_
@@ -1308,7 +1308,7 @@ test_close_intro_circuit_failure(void *arg)
   /* Code path will log this exit so build it. */
   ocirc->build_state->chosen_exit = extend_info_new("TestNickname", digest,
                                                     NULL, NULL, NULL, &addr,
-                                                    4242, NULL);
+                                                    4242, NULL, false);
   ed25519_pubkey_copy(&ocirc->hs_ident->intro_auth_pk, &intro_kp.pubkey);
 
   /* On free, we should get an unreachable failure. */
@@ -1331,7 +1331,7 @@ test_close_intro_circuit_failure(void *arg)
   /* Code path will log this exit so build it. */
   ocirc->build_state->chosen_exit = extend_info_new("TestNickname", digest,
                                                     NULL, NULL, NULL, &addr,
-                                                    4242, NULL);
+                                                    4242, NULL, false);
   ed25519_pubkey_copy(&ocirc->hs_ident->intro_auth_pk, &intro_kp.pubkey);
 
   circuit_mark_for_close(circ, END_CIRC_REASON_TIMEOUT);