]> git.ipfire.org Git - thirdparty/dnspython.git/commitdiff
Fix elliptic curve test deprecation warning from cryptography 42.
authorBob Halley <halley@dnspython.org>
Sat, 27 Jan 2024 13:45:35 +0000 (05:45 -0800)
committerBob Halley <halley@dnspython.org>
Sat, 27 Jan 2024 13:45:35 +0000 (05:45 -0800)
We were passing a curve class as the curve parameter in
testSignatureECDSAP256SHA256 and testSignatureECDSAP384SHA384,
not an instance of the curve class.  The official API has
always been to pass an instance, but it tolerated passing a class.
Starting with Cryptogrphy 42, passing a class is deprecated.

tests/test_dnssec.py

index c4a8d684cc6b3bbdb94df43733e46e3d87604163..c2cdb8ecbece8695c7f97f173cce2f81ee77afe6 100644 (file)
@@ -1398,11 +1398,11 @@ class DNSSECSignatureTestCase(unittest.TestCase):
         self._test_signature(key, dns.dnssec.Algorithm.RSASHA256, abs_soa)
 
     def testSignatureECDSAP256SHA256(self):  # type: () -> None
-        key = ec.generate_private_key(curve=ec.SECP256R1, backend=default_backend())
+        key = ec.generate_private_key(curve=ec.SECP256R1(), backend=default_backend())
         self._test_signature(key, dns.dnssec.Algorithm.ECDSAP256SHA256, abs_soa)
 
     def testSignatureECDSAP384SHA384(self):  # type: () -> None
-        key = ec.generate_private_key(curve=ec.SECP384R1, backend=default_backend())
+        key = ec.generate_private_key(curve=ec.SECP384R1(), backend=default_backend())
         self._test_signature(key, dns.dnssec.Algorithm.ECDSAP384SHA384, abs_soa)
 
     def testSignatureED25519(self):  # type: () -> None