Added Javascript, Cookies, and Templatization requirements to Hacking

Bugzilla.

diff --git a/docs/sgml/patches.sgml b/docs/sgml/patches.sgml
index ec68667b4765d25b4bebbae03aeee72a5225014d..dcbe626bec488eb5661b9285e212d059864b6d79 100644 (file)
--- a/docs/sgml/patches.sgml
+++ b/docs/sgml/patches.sgml
@@ -307,7 +307,9 @@ grep (/$value/, @array);
       </para>
       <para>
         What appears below if a brief summary, please refer to the perl style
-        guide if you don't see your question covered here.
+        guide if you don't see your question covered here.  It is much better to submit
+       a patch which fails these criteria than no patch at all, but please try to meet
+       these minimum standards when submitting code to Bugzilla.
       </para>
       <itemizedlist>
         <listitem>
@@ -353,6 +355,17 @@ else
             </programlisting>
           </para>
         </listitem>
+
+       <listitem>
+         <para>
+           Cookies
+         </para>
+         <para>
+           Bugzilla uses cookies to ease the user experience, but no new patches
+           should <emphasis>require</emphasis> user-side cookies.
+         </para>
+       </listitem>
+
         <listitem>
           <para>
             File Names
@@ -365,6 +378,17 @@ else
             can cause confusion in CVS and other mozilla.org utilities.
           </para>
         </listitem>
+
+       <listitem>
+         <para>
+           Javascript dependencies
+         </para>
+         <para>
+           While Bugzilla uses Javascript to make the user experience easier, no patch
+           to Bugzilla should <emphasis>require</emphasis> Javascript.
+         </para>
+       </listitem>
+
        <listitem>
          <para>
            Schema Changes
@@ -375,6 +399,16 @@ else
          </para>
        </listitem>
 
+       <listitem>
+         <para>
+           Templatization
+         </para>
+         <para>
+           Patches to Bugzilla need to support templates so they do not force user interface choices
+           on Bugzilla administrators.
+         </para>
+       </listitem>
+
         <listitem>
           <para>
             Variable Names
@@ -389,6 +423,7 @@ else
              on the same screen as <computeroutput>my $ret = "";</computeroutput>.
           </para>
         </listitem>
+
         <listitem>
           <para>
             Cross Database Compatability

diff --git a/docs/xml/patches.xml b/docs/xml/patches.xml
index ec68667b4765d25b4bebbae03aeee72a5225014d..dcbe626bec488eb5661b9285e212d059864b6d79 100644 (file)
--- a/docs/xml/patches.xml
+++ b/docs/xml/patches.xml
@@ -307,7 +307,9 @@ grep (/$value/, @array);
       </para>
       <para>
         What appears below if a brief summary, please refer to the perl style
-        guide if you don't see your question covered here.
+        guide if you don't see your question covered here.  It is much better to submit
+       a patch which fails these criteria than no patch at all, but please try to meet
+       these minimum standards when submitting code to Bugzilla.
       </para>
       <itemizedlist>
         <listitem>
@@ -353,6 +355,17 @@ else
             </programlisting>
           </para>
         </listitem>
+
+       <listitem>
+         <para>
+           Cookies
+         </para>
+         <para>
+           Bugzilla uses cookies to ease the user experience, but no new patches
+           should <emphasis>require</emphasis> user-side cookies.
+         </para>
+       </listitem>
+
         <listitem>
           <para>
             File Names
@@ -365,6 +378,17 @@ else
             can cause confusion in CVS and other mozilla.org utilities.
           </para>
         </listitem>
+
+       <listitem>
+         <para>
+           Javascript dependencies
+         </para>
+         <para>
+           While Bugzilla uses Javascript to make the user experience easier, no patch
+           to Bugzilla should <emphasis>require</emphasis> Javascript.
+         </para>
+       </listitem>
+
        <listitem>
          <para>
            Schema Changes
@@ -375,6 +399,16 @@ else
          </para>
        </listitem>
 
+       <listitem>
+         <para>
+           Templatization
+         </para>
+         <para>
+           Patches to Bugzilla need to support templates so they do not force user interface choices
+           on Bugzilla administrators.
+         </para>
+       </listitem>
+
         <listitem>
           <para>
             Variable Names
@@ -389,6 +423,7 @@ else
              on the same screen as <computeroutput>my $ret = "";</computeroutput>.
           </para>
         </listitem>
+
         <listitem>
           <para>
             Cross Database Compatability