Fix for bug 69616: If you have tweakparams privs, the "Sanity check" link was listed...

it appeared as if you were going to edit the sanity checks if you clicked on it, when in fact you were going to run them.
This patch rewords the links so Sanity check is in a group by itself in the block of links on the right.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x2

diff --git a/CGI.pl b/CGI.pl
index 6bcb1ba02285e4599e2725c6b6f69b5b69aad117..3c0795d44d335df9cb14ef613e6560c1e4ab5d82 100644 (file)
--- a/CGI.pl
+++ b/CGI.pl
@@ -1285,7 +1285,6 @@ Actions:
         $html .= "</TD><TD>&nbsp;</TD><TD VALIGN=middle><NOBR>Edit <a href='userprefs.cgi'>prefs</a></NOBR>";
         if (UserInGroup("tweakparams")) {
             $html .= ", <a href=editparams.cgi>parameters</a>";
-            $html .= ", <a href=sanitycheck.cgi><NOBR>sanity check</NOBR></a>";
         }
         if (UserInGroup("editusers") || $blessgroupset) {
             $html .= ", <a href=editusers.cgi>users</a>";
@@ -1301,6 +1300,10 @@ Actions:
         if (UserInGroup("editkeywords")) {
             $html .= ", <a href=editkeywords.cgi>keywords</a>";
         }
+        if (UserInGroup("tweakparams")) {
+            $html .= " | <a href=sanitycheck.cgi><NOBR>Sanity check</NOBR></a>";
+        }
+
         $html .= " | <NOBR><a href=relogin.cgi>Log out</a> $::COOKIE{'Bugzilla_login'}</NOBR>";
         $html .= "</TD></TR>";