Fixed for_qs for urlencode. This fixes #515

diff --git a/CHANGES b/CHANGES
index 987a168cf31d18eb1e667c8f0401176fb112532d..4e5df26c9934f6ef11d3983f176e12446b46ef5f 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -6,6 +6,8 @@ Version 2.8.1
 
 (unreleased bugfix release)
 
+- Fixed the `for_qs` flag for `urlencode`.
+
 Version 2.8
 -----------
 (codename Replacement, released on July 26th 2015)

diff --git a/jinja2/utils.py b/jinja2/utils.py
index cdd4cd3af05c34be55eaba61761d3f25e44d8b00..612d5c3d8bb9b7bdb28a10e1fee0f174d8bc69cf 100644 (file)
--- a/jinja2/utils.py
+++ b/jinja2/utils.py
@@ -295,7 +295,7 @@ def unicode_urlencode(obj, charset='utf-8', for_qs=False):
         obj = text_type(obj)
     if isinstance(obj, text_type):
         obj = obj.encode(charset)
-    safe = for_qs and b'' or b'/'
+    safe = not for_qs and b'/' or b''
     rv = text_type(url_quote(obj, safe))
     if for_qs:
         rv = rv.replace('%20', '+')