[BUG] dynamic connection throttling could return a max of zero conns

srv_dynamic_maxconn() is clearly documented as returning at least 1
possible connection under throttling. But the computation was wrong,
the minimum 1 was divided and got lost in case of very low maxconns.

Apply the MAX(1, max) before returning the result in order to ensure
that a newly appeared server will get some traffic.

diff --git a/src/queue.c b/src/queue.c
index 178f1877c23b18a3c3084332d5701f2789a59be0..905994abba579e9c435b3f040d7f044f9e9f2445 100644 (file)
--- a/src/queue.c
+++ b/src/queue.c
@@ -55,8 +55,8 @@ unsigned int srv_dynamic_maxconn(const struct server *s)
            now.tv_sec < s->last_change + s->slowstart &&
            now.tv_sec >= s->last_change) {
                unsigned int ratio;
-               ratio = MAX(1, 100 * (now.tv_sec - s->last_change) / s->slowstart);
-               max = max * ratio / 100;
+               ratio = 100 * (now.tv_sec - s->last_change) / s->slowstart;
+               max = MAX(1, max * ratio / 100);
        }
        return max;
 }