Correct statement to actually be the intended assert statement.

e3f4cfc7 introduced a LWLockHeldByMe() call, without the corresponding
Assert() surrounding it.

Spotted by Coverity.

Backpatch: 9.1+, like the previous commit

diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
index 3b2c40ce42c936697f609bb1c6d7aac611a28340..3ae203fde013f25e7273fbe2d50461220e0acd00 100644 (file)
--- a/src/backend/storage/buffer/bufmgr.c
+++ b/src/backend/storage/buffer/bufmgr.c
@@ -2564,7 +2564,7 @@ FlushOneBuffer(Buffer buffer)
 
        bufHdr = &BufferDescriptors[buffer - 1];
 
-       LWLockHeldByMe(bufHdr->content_lock);
+       Assert(LWLockHeldByMe(bufHdr->content_lock));
 
        FlushBuffer(bufHdr, NULL);
 }