]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
fs/ntfs3: fix Smatch warnings
authorKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Wed, 15 Apr 2026 15:43:47 +0000 (17:43 +0200)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Thu, 16 Apr 2026 08:28:32 +0000 (10:28 +0200)
Initialize err in ni_allocate_da_blocks_locked() and correct the
pre_alloc condition in attr_allocate_clusters().

Suggested-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/attrib.c
fs/ntfs3/frecord.c

index 6b5b58ebbf852049b0a0a5336a00facf31dc66d2..e61c5bf7e27e4403dbb5a7a97837f704a9a33c18 100644 (file)
@@ -173,7 +173,7 @@ int attr_allocate_clusters(struct ntfs_sb_info *sbi, struct runs_tree *run,
 
                if (err == -ENOSPC && pre) {
                        pre = 0;
-                       if (*pre_alloc)
+                       if (pre_alloc)
                                *pre_alloc = 0;
                        continue;
                }
index c0b9ca2426abcb9cbd34df5c39f9674f2887876f..7b035da63c1219ef5f3b51f2fd2e2f9911b785c9 100644 (file)
@@ -3267,7 +3267,7 @@ int ni_allocate_da_blocks(struct ntfs_inode *ni)
  */
 int ni_allocate_da_blocks_locked(struct ntfs_inode *ni)
 {
-       int err;
+       int err = 0;
 
        if (!ni->file.run_da.count)
                return 0;