]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
comedi: aio_iiro_16: Add sanity checks for I/O base address
authorIan Abbott <abbotti@mev.co.uk>
Fri, 30 Jan 2026 16:47:30 +0000 (16:47 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2026 13:49:36 +0000 (15:49 +0200)
The "aio_iiro_16" driver uses an admin-supplied configuration option
(`it->options[0]`) to configure the I/O port base address of a supported
board (IIRO-16).  It currently allows any base address to be configured
but the hardware only supports base addresses (set by on-board jumpers)
in the range 0x100 to 0x3F8 on 8-byte boundaries.

Add a sanity check to ensure the device is not configured at an
unsupported base address.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://patch.msgid.link/20260130170416.49994-6-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/comedi/drivers/aio_iiro_16.c

index 739cc4db52ac7e9d030b2e7d7d3d057041b79f54..00d0bb0f6256929eddabcda887682fbe53a5e6cc 100644 (file)
@@ -167,7 +167,8 @@ static int aio_iiro_16_attach(struct comedi_device *dev,
        struct comedi_subdevice *s;
        int ret;
 
-       ret = comedi_request_region(dev, it->options[0], 0x8);
+       ret = comedi_check_request_region(dev, it->options[0], 0x8,
+                                         0x100, 0x3ff, 0x8);
        if (ret)
                return ret;